lkml.org 
[lkml]   [2002]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.8 IDE 38
    On Thu, Apr 18, 2002 at 11:14:09AM +0200, Martin Dalecki wrote:
    > @@ -523,6 +513,12 @@
    > unsigned autodma : 1; /* automatically try to enable DMA at boot */
    > unsigned udma_four : 1; /* 1=ATA-66 capable, 0=default */
    > unsigned highmem : 1; /* can do full 32-bit dma */
    > + byte slow; /* flag: slow data port */
    > + unsigned no_io_32bit : 1; /* disallow enabling 32bit I/O */
    > + byte io_32bit; /* 0=16-bit, 1=32-bit, 2/3=32bit+sync */
    > + unsigned no_unmask : 1; /* disallow setting unmask bit */
    > + byte unmask; /* flag: okay to unmask other irqs */
    > +

    Just cosmetic... This causes the layout to be:

    1 bit
    1 bit
    1 bit
    align to word
    1 byte
    align to word
    1 bit
    align to word
    1 byte
    align to word
    1 bit
    align to word
    1 byte
    align to word

    which is rather wasteful. Any chance you can group the bits together
    and the bytes together?

    --
    Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
    http://www.arm.linux.org.uk/personal/aboutme.html

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:5.156 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site