Messages in this thread | | | Date | Mon, 15 Apr 2002 10:11:52 +0200 | From | Martin Dalecki <> | Subject | Re: [PATCH] 2.5.8 IDE 34 |
| |
Jens Axboe wrote: > On Mon, Apr 15 2002, Martin Dalecki wrote: > > Two comments -- > > Could you please _not_ just rearrange comments or change style in ide-cd > just for the sake cleaning, it's very annoying when one has patches that > need to be adapted every time. And it serves zero purpose. Thanks.
Please do me a small favour and use an editor which highlights trailing white spaces please? The bandwidth waste caused by this is an waste of energy and causes a significant amount of environmental pollution...
> I changed the CONFIG_BLK_DEV_IDEPCI stuff to always include the pci_dev > in the hwgroup, and just leave it at NULL if not defined. This cleans up > some ifdefs, I think this is the better approach.
Agreed.
> I'll sync the latest tcq stuff with you later today, it gets the > enabling right etc.
Fine. I would like to go on with the request handling changes in ide-cd.c thereafter.
> And a last comment not directly related to this particular patch -- when > you include something and change minor stuff along the way, please do it > in two steps. One that includes a patch, and a second version that > changes what you want to change. That makes merging _so_ much easier. > Thanks.
OK - sorry. I try already to make the granularity of the patches smaller. Since I always apply patches line by line I wasn't aware of your "modus operandi".
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |