Messages in this thread | | | Date | Sat, 23 Mar 2002 14:25:17 +0100 | From | Martin Dalecki <> | Subject | Re: BUG: 2.4.18 & ALI15X3 DMA hang on boot |
| |
John Langford wrote: > I did a small tweak and "it seems to work". I have no idea whether or > not this breaks other configs. > > -John > > --- linux/drivers/ide/alim15x3.c Sun Jul 15 19:22:23 2001 > +++ linux-2.4.18-hack/drivers/ide/alim15x3.c Fri Mar 22 12:31:28 2002 > @@ -574,17 +574,7 @@ > * set south-bridge's enable bit, m1533, 0x79 > */ > pci_read_config_byte(isa_dev, 0x79, &tmpbyte); > - if (m5229_revision == 0xC2) { > - /* > - * 1543C-B0 (m1533, 0x79, bit 2) > - */ > - pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x04); > - } else if (m5229_revision >= 0xC3) { > - /* > - * 1553/1535 (m1533, 0x79, bit 1) > - */ > - pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x02); > - } > + pci_write_config_byte(isa_dev, 0x79, tmpbyte | 0x04); > /* > * Ultra66 cable detection (from Host View) > * m5229, 0x4a, bit0: primary, bit1: secondary 80 pin
According to the fact that this is setting the enable bit of the south bridge on this host, the issue appears to be not tactile. (If your fix where wrong, your system would simply not work at all.) I will therefore just simply take this patch as it is... And then I couldn't find any other places where the 0x02 bit would be used on register 0x79.
Possibly someone just misscounted the bits reading some errate for different reviaions... or just the errata was wrong.
But before could you just tell the m5229_revision value on your system?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |