Messages in this thread | | | Date | Mon, 11 Mar 2002 20:23:51 +0100 | From | Martin Dalecki <> | Subject | Re: [PATCH] 2.5.6 IDE 19, return of taskfile |
| |
Gunther Mayer wrote:
> Currently your taskfile access is hardcoded in tables in your ide patches and this is > > inflexible (e.g. cannot support future commands, unknown at the time of your writing)
And vendor specific commands which they don't wan't the world to know about and the list would be complete. Anyway thank you for this well done clarification.
> Your "case" structures and accompanying code are considered kernel bloat, because > it can be done in user code (with a "generic ioctl" and a "generic task file state > machine" which surely > can be extracted from your patch).
The worsest thing about them is that they are translating the plain commands to some obscure internal values and vice versa. This is making it a bit tedious to remove them directly. And it's in esp. error prone.
The fortunate thing is that the state machine points can be really easly identifyed. The unfortunate thing is that there is simple that much plain poor C coding in the drivers code that it will just take time until one can get at this. Please see the notes inside my patches about buffer overruns... methods called twice and modularization as well as comments about functions passing timeout pointers, which are taken by reusing the IRQ code path and so on...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |