Messages in this thread | | | Date | Thu, 21 Feb 2002 03:06:46 -0800 (PST) | From | Andre Hedrick <> | Subject | Re: [PATCH] 2.5.5 IDE cleanup 11 |
| |
On Thu, 21 Feb 2002, Jeff Garzik wrote:
> > @@ -2929,7 +2928,6 @@ > > capacity: ide_cdrom_capacity, > > special: NULL, > > proc: NULL, > > - driver_init: ide_cdrom_init, > > driver_reinit: ide_cdrom_reinit, > > }; > > > > @@ -2967,7 +2965,7 @@ > > DRIVER(drive)->busy--; > > failed--; > > > > - ide_register_module(&ide_cdrom_driver); > > + revalidate_drives(); > > MOD_DEC_USE_COUNT; > > return 0; > > } > > hum, I'm not sure that removing ->driver_init is a good idea. > > Seems like a loss of flexibility to me, not a cleanup, and I wonder if > you have thought through all the paths that wind up calling > ->driver_init.
Nah, go ahead add it.
I have been meaning to start another driver from scratch that is fully threaded IO and can deal with register core operations independent of the how the arch calls the transport.
Cheers,
Andre Hedrick Linux Disk Certification Project Linux ATA Development
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |