Messages in this thread | | | Date | Sat, 2 Feb 2002 19:02:42 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] Generic HDLC patch for 2.5.3 |
| |
On Sun, Feb 03, 2002 at 12:33:59AM +0100, Krzysztof Halasa wrote: > Hi, > > The attached file updates Linux 2.5.3 generic HDLC, please apply. > > The patch includes: > - new SIOCDEVICE ioctl for setting all protocol and hardware parameters > of (HDLC) network devices, instead of using PRIVATE netdev ioctls > (details in hdlc.h and respective hdlc_*.c and/or N2 + C101 drivers) > - the HDLC code is now split into hdlc_generic.c, hdlc_fr.c, > hdlc_cisco.c etc. files, > - all protocol parameters (timeouts etc.) are (should/aim) now configurable > via SIOCDEVICE ioctl,
Linus,
Please revert, or do not apply, this patch.
ftp://ftp.pm.waw.pl/pub/linux/hdlc/experimental/hdlc-2.5.3.patch.gz
It adds undiscussed networking changed which I very much doubt DaveM would approve of, and I do not approve of: SIOCDEVICE is far too generic for inclusion, and it adds a structure for passing untyped data which is very definitely non-portable.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |