Messages in this thread | | | Date | Tue, 19 Feb 2002 02:47:17 -0500 (EST) | From | Alexander Viro <> | Subject | Re: BKL removal from VFS |
| |
On Tue, 19 Feb 2002, Nakayama Shintaro wrote:
> I've found great BKL contention when running multiple postmark > benchmarks. Here is the postmark results with lock contention > sampled by lockmeter.
Conflicts with (and massively duplicates) patches that already went into 2.5. Absolutely useless wrt mount() locking changes (except for remount they can't race with filesystem code even in principle and definitely don't need system-wide exclusion among themselves). Has a nice DoS potential (on OOM). Too large and changes too many things to be acceptable at one chunk even if none of the above would apply. Consider it vetoed.
Seriously, just watching the changelogs would show that it has no chance to be applied.
I hadn't checked for races, but e.g. ext2_readdir() losing BKL without corresponding changes to lseek() looks very suspicious. I'm more than sure that there's more - after doing that BKL-shifting in recent 2.5. E.g. I'm pretty sure that you are screwing ->i_nlink checks.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |