Messages in this thread | | | Date | Fri, 15 Feb 2002 18:50:16 +0100 | From | Pierre Rousselet <> | Subject | Re: 2.5.5-pre1 rmmod usb-uhci hangs |
| |
Greg KH wrote: > On Fri, Feb 15, 2002 at 03:54:40PM +0100, Pierre Rousselet wrote: > >>with 2.5.5-pre1 usb-uhci module can't unload. rmmod hangs, leaving the >>system unstable. in one circumstance the box freezed with an oops >>involving swapper pid0 . this doesn't happen with 2.5.4 >> > > Try this (untested, I haven't rebooted yet) patch: > > thanks, > > greg k-h > > > diff -Nru a/drivers/usb/usb.c b/drivers/usb/usb.c > --- a/drivers/usb/usb.c Thu Feb 14 22:47:21 2002 > +++ b/drivers/usb/usb.c Thu Feb 14 22:47:21 2002 > @@ -1979,11 +1979,11 @@ > if (driver->owner) > __MOD_DEC_USE_COUNT(driver->owner); > /* if driver->disconnect didn't release the interface */ > - if (interface->driver) { > - put_device (&interface->dev); > + if (interface->driver) > usb_driver_release_interface(driver, interface); > - } > } > + /* remove our device node for this interface */ > + put_device(&interface->dev); > } > } > > > no, it doesn't solve the problem. i would like to test it whith preemtible kernel not set but it doesn't boot.
with both 2.5.4 and 2.5.5-pre1 when loading usb-uhci usb.c reports 2 devices : device 1 : USB UHCI Root Hub device 2 : Alcatel Speed Touch USB (the driver module and firmware are not loaded at this stage)
when rmmoding usb-uhci with 2.5.4 usb.c reports: usb.c: USB disconnect on device 1 usb.c: USB disconnect on device 2
with 2.5.5-pre1 usb.c: USB disconnect on device 1 and nothing else. Pierre -- ------------------------------------------------ Pierre Rousselet <pierre.rousselet@wanadoo.fr> ------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |