Messages in this thread | | | Date | Thu, 14 Feb 2002 12:13:38 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [RFC][PATCH 2.4.17] Your suggestions for fast path walk |
| |
Hi,
On Wed, 13 Feb 2002, Hanna Linder wrote:
> - return NULL; > + struct dentry *dentry = NULL;
Could you please configure your editor to use tabs instead of spaces? It would make the patch smaller and easier to read.
> + if(flags & LOOKUP_LOCKED){
IMO it would be better to use a count, which limits to number of lookups done with the spinlock held. This count could be put into nameidata, this would change the prototype of cached_lookup/lookup_hash into using a pointer to struct nameidata, but AFAICS it's not a really problem, as most of the time the data is already available in a nameidata struct. Since spinlocks are a dummy on UP, it would make sense to make this test a inline function/macro, where it could be made a dummy as well.
bye, Roman
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |