Messages in this thread | | | Subject | Re: [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c | From | Alan Cox <> | Date | 12 Dec 2002 01:29:45 +0000 |
| |
On Wed, 2002-12-11 at 22:28, Bob Miller wrote: > The function, cs5520_tune_chipset() is declared to return an int. > Added a return statement instead of just falling of off the bottom. > > diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c > --- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002 > +++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002 > @@ -166,6 +166,8 @@ > /* ATAPI is harder so leave it for now */ > if(!error && drive->media == ide_disk) > error = hwif->ide_dma_on(drive); > + > + return error;
Eep thats a nasty little bug, lucky my compiler left the error value in %eax anyway good spotting
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |