Messages in this thread | | | Date | Sun, 3 Nov 2002 21:10:51 -0800 | From | Richard Henderson <> | Subject | Re: [PATCH] work around duff ABIs |
| |
On Sun, Oct 20, 2002 at 05:31:47AM +0100, Matthew Wilcox wrote: > -asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf, > - size_t count, loff_t pos) > +#ifdef __BIG_ENDIAN > +asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf, size_t count, > + unsigned int high, unsigned int low) > +#else > +asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf, size_t count, > + unsigned int low, unsigned int high) > +#endif
Broken for actual 64-bit targets.
I'd suggest frobbing the arguments in arch specific code for those 32-bit targets that do pad 64-bit arguments to the next even/odd register. I disbelieve you can do anything cleanly here.
r~ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |