Messages in this thread | | | Date | Sat, 30 Nov 2002 14:13:39 -0800 | From | Andrew Morton <> | Subject | Re: [BUG] ext3-orlov for 2.4 |
| |
"J.A. Magallon" wrote: > > HI all... > > Tell me if this is correct. GCC-3.2 spits a wrning like this when > building -jam, I did not noticed before: > > ialloc.c: In function `ext3_new_inode': > ialloc.c:546: warning: comparison between pointer and integer > ialloc.c:682: warning: label `out' defined but not used > ialloc.c:520: warning: `gdp' might be used uninitialized in this function > > Line is question is: > if (gdp == -1) > goto fail; > It comes from the orlov-allocator for ext3.
gdp will be NULL on failure. The above code isn't right.
> Should not the structure be: > gdp = ext3_get_group_desc (sb, group, &bh2); > if (!gdp) > goto fail;
yes.
> Can anybody check 2.5 for this also ? >
Is OK. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |