Messages in this thread | | | Date | Fri, 29 Nov 2002 12:45:00 +1100 | From | Nathan Scott <> | Subject | Re: [RELEASE] module-init-tools 0.8 |
| |
On Fri, Nov 29, 2002 at 11:59:49AM +1100, Rusty Russell wrote: > In message <Pine.LNX.4.44.0211272325370.924-100000@lap.molina> you write: > > With the patch you included, I get the following: > > > > In file included from include/linux/raid/md.h:27, > > from init/do_mounts.c:25: > > include/linux/module.h:159: parse error before "Elf32_Sym" > > Argh.... Put back the #include <linux/elf.h> at the top of the file. > It's required for CONFIG_KALLSYMS=y. > > The main reason for separating out moduleloader.h was so modules.h > didn't include elf.h, because xfs defines AT_GID and AT_UID itself. > The kallsyms patch put that back. > > We could make module.symtab a void*, but that's just wrong. I think > we actually have to solve this clash, rather than hack around it, > since this is going to be a recurring problem. > > Steve? Changing the prefix on xfs or elf seems equally painful (xfs > because it'll be a big patch, elf because it's standardized and been > like that forever).
We changed XFS when this problem first came up. Linus hasn't yet pulled from Christoph's bitkeeper tree though, so we're a bit out of sync at the moment.
cheers.
-- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |