Messages in this thread | | | From | Andreas Gruenbacher <> | Subject | Re: [Ext2-devel] [RFC] [PATCH 1/4] Add extended attributes to ext2/3 | Date | Tue, 8 Oct 2002 20:47:04 +0200 |
| |
On Tuesday 08 October 2002 20:38, Andrew Morton wrote: > [...] > > > This first patch creates a generic interface for registering caches > > > with the VM subsystem so that they can react appropriately to memory > > > pressure. > > > > I'd suggest Ed Tomlinson's much saner interface that adds a third > > callbackj to kmem_cache_t (similar to the Solaris implementation) > > instead. > > > > Doing this outside slab is not a good idea (and XFS currently does > > it too - in it's own code which should be replaced with Ed's one) > > Yup, although that's a fairly minor point in this context.. > > The shrinker callback code is not actually in Linus's kernel > at present. I'm kind of sitting on it until I've had time > to ponder the dirty great lock which Ed added ;)
Switching to Ed's code once it's in the kernel may be worthwhile; until then the dumb shrinking approaah doesn't to do much harm IMHO.
--Andreas.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |