lkml.org 
[lkml]   [2002]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Ext2-devel] [RFC] [PATCH 2/4] Add extended attributes to ext2/3
On Tue, Oct 08, 2002 at 02:08:14PM -0400, tytso@mit.edu wrote:
>
> This is the second of four patches which add extended attribute support
> to the ext2 and ext3 filesystems. Please comment and bleed.
>
> This patch creates a meta block cache which is utilized by the ext3 and
> ext2 extended attribute patch (patches 3 and 4, respectively). This
> cache allows directory blocks to be indexed by multiple keys. In the
> case of the extended attribute patches, it is used to look up blocks by
> both the block number and by the hash of the extended attributes. This
> is extremely important to allow the sharing of acl's when stored as
> extended attributes. Otherwise every single file would require its own,
> separate, one block overhead to store then ACL, even though there might
> be a large number of files that have the same ACL.

The code doesn't really make æny sense outside ext2/ext3. I'd suggest you
move it there instead of bloating every kernel with it unconditionally.

__mb_cache_entry_in_lru() is buggy and can't work anymore now that akpm removed
some list_head debugging.

And please get rid of the LINUX_VERSION_CODE checks..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.231 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site