Messages in this thread | | | Date | Fri, 04 Oct 2002 15:37:59 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] direct-IO API change |
| |
Linus Torvalds wrote: > > On Fri, 4 Oct 2002, Chuck Lever wrote: > > > > this patch adds a "struct file *" argument to direct I/O. this is needed > > by NFS direct I/O to make the file's credentials available to direct I/O > > subroutines. we can't remove "struct inode *" yet because the raw driver > > still needs it. > > Why isn't the raw driver changed to just use file->f_dentry->d_inode > instead? >
Because the file handle which we have is for /dev/raw/raw0, not for /dev/hda1.
The raw driver binds to major/minor, not a file*. I considered changing that (change userspace to pass the open fd). But didn't.
An alternative would be to rewrite i_mapping for /dev/raw/raw0 to be bdev->bd_inode->i_mapping. I guess we should look at doing that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |