Messages in this thread | | | Date | Tue, 22 Oct 2002 12:43:53 +0200 (CEST) | From | Jaroslav Kysela <> | Subject | Re: sound/core/wrappers.c __GENKSYMS__ usage |
| |
On Mon, 21 Oct 2002, Sam Ravnborg wrote:
> Hi Jaroslav > > The usage of __GENKSYMS__ in sound/core/wrappers.c looks wrong. > > >From the file: > #include <linux/version.h> > #include <linux/config.h> > #ifdef ALSA_BUILD > #if defined(CONFIG_MODVERSIONS) && !defined(__GENKSYMS__) && !defined(__DEPEND__) > #define MODVERSIONS > #include <linux/modversions.h> > #include "sndversions.h" > #endif > #endif > > So __GENKSYMS__ etc is used to protect against inclusion of modversions.h > and sndversion.h. > The latter is not present in my tree (2.5.44). > __DEPEND__ is no longer used. > > I do not see the purpose of this - please explain.
It's for compatibility with older kernels. We use same sources for 2.2 and 2.4 kernels. Also notice that "problematic" #if is after ALSA_BUILD and it's not defined for Linux kernel (we use this definition internally for our build system).
Anyway, I'll move this code outside the kernel tree.
Jaroslav
----- Jaroslav Kysela <perex@suse.cz> Linux Kernel Sound Maintainer ALSA Project http://www.alsa-project.org SuSE Linux http://www.suse.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |