Messages in this thread | | | Subject | Re: [PATCH] 2.5.44: lkcd (9/9): dump driver and build files | From | "Suparna Bhattacharya" <> | Date | Tue, 22 Oct 2002 20:35:36 +0530 |
| |
On Mon, 21 Oct 2002 19:43:20 +0530, Christoph Hellwig wrote:
>> + >> + if ((dump_bio = kmalloc(sizeof(struct bio), GFP_KERNEL)) == NULL) { + >> DUMP_PRINTF("Cannot allocate bio\n"); + retval = -ENOMEM; >> + goto err2; >> + } > > Shouldn't you use the generic bio allocator? >
Not sure that this should come from the bio mempool. Objects allocated from the mem pool are expected to be released back to the pool within a reasonable period (after i/o is done), which is not quite the case here.
Dump preallocates the bio early when configured and holds on to it all through the time the system is up (avoids allocs at actual dump time). Doesn't seem like the right thing to hold on to a bio mempool element that long.
Regards Suparna - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |