Messages in this thread | | | Date | Fri, 18 Oct 2002 09:46:06 +0400 | From | Andrey Panin <> | Subject | Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43 |
| |
On Thu, Oct 17, 2002 at 10:21:12AM -0400, Jeff Garzik wrote: > Andrey Panin wrote: > >diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104xc > >linux/drivers/net/tulip/de2104x.c > >--- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002 > >+++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002 > >@@ -2216,7 +2216,7 @@ > > .name = DRV_NAME, > > .id_table = de_pci_tbl, > > .probe = de_init_one, > >- .remove = de_remove_one, > >+ .remove = __devexit_p(de_remove_one), > > #ifdef CONFIG_PM > > .suspend = de_suspend, > > .resume = de_resume, > > > alas, it is incorrect, as no one hotplugs this hardware.
This patch is not about hotplugging, absence of __devexi_p() makes impossible to link this driver in kernel.
-- Andrey Panin | Embedded systems software developer pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net[unhandled content-type:application/pgp-signature] | |