Messages in this thread | | | Date | Thu, 31 Jan 2002 22:41:17 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] 2.5.3 remove global semaphore_lock spin lock. |
| |
On Thu, Jan 31, 2002 at 03:55:02PM -0800, Andrew Morton wrote: > > + unsigned long flags; > > + wq_write_lock_irqsave(&sem->wait.lock, flags); > > - spin_lock_irq(&semaphore_lock); > > I rather dislike spin_lock_irq(), because it's fragile (makes
It's less flexible for architectures, too.
spin_lock_irqsave is considered 100% portable AFAIK, and I make it my own policy to s/_irq/_irqsave/ when the opportunity strikes in my PCI drivers.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |