Messages in this thread Patch in this message | | | Date | Thu, 3 Jan 2002 12:36:23 -0700 | From | Andreas Dilger <> | Subject | Re: [CFT] [JANITORIAL] Unbork fs.h |
| |
On Jan 03, 2002 15:07 -0200, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 03, 2002 at 06:05:19PM +0100, Daniel Phillips escreveu: > > On January 3, 2002 05:36 pm, Arnaldo Carvalho de Melo wrote: > > > Maybe CodingStyle should have an entry for this, I'd vote for this style: > > > > > > static inline struct inode *new_inode(struct super_block *sb) > > > > OK, I'll revise it to that style. Shall we start an official janitor's > > style guide? ;-) > > Nah, I'll try and submit some patches do CodingStyle, for discussion. Hey, > people here _love_ to discuss important things like coding style, dontcha?
While you are at it, the following patch to scripts/Lindent makes it do the right thing as well. From what I can see, the following is more consistent with the actual practise in the kernel code. Sadly, indent (v2.2.4) will break the indenting of any line with a colon (e.g. labels, named struct initialization), so it is not possible to just run Lindent on the whole tree.
I removed the following two options: -bs: Put a space between sizeof and its argument. -psl: Put the type of a procedure on the line before its name.
I added the following options: -nbbo: don't prefer to break lines before boolean operators -ci8: indent continuation lines 8 characters -ncs: Do not put a space after cast operators. -lps: Leave space between # and preprocessor directive. -pmt: Preserve access and modification times on output files. -npro: Do not read .indent.pro files.
diff -u linux.orig/scripts/Lindent linux/scripts/Lindent --- linux.orig/scripts/Lindent Wed Nov 28 23:25:14 2001 +++ linux/scripts/Lindent Thu Jan 3 12:10:00 2002 @@ -1,2 +1,37 @@ #!/bin/sh -indent -kr -i8 -ts8 -sob -l80 -ss -bs -psl "$@" +indent -kr -nbbo -ci8 -ncs -i8 -l80 -lps -pmt -npro -sob -ss -ts8 "$@" Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |