Messages in this thread | | | Date | Mon, 21 Jan 2002 21:14:37 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Patch for ymfpci in 2.5.x |
| |
On Tue, 22 Jan 2002, Pete Zaitcev wrote: > > I think something like this would be better than one more > totally nonsesical random #define:
No.
Why don't you call it something SANE, like "default_gain" or something.
Anybody who uses variable names like "le_0x40000000" is just horribly misguided. Never EVER do that. You're better off just writing it out as "cpu_to_le32(0x40000000)" in that case.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |