Messages in this thread | | | From | "Tim Pepper" <> | Date | Thu, 17 Jan 2002 16:21:40 -0800 | Subject | Re: BLKGETSIZE64 (bytes or sectors?) |
| |
On Thu 17 Jan at 23:48:16 +0000 Andries.Brouwer@cwi.nl done said: > Matt_Domsch@dell.com wrote, and he is right: > > Yes, in bytes. blkpg.c has to be fixed. > Several people submitted patches. Sooner or later I suppose > this will be fixed. > >--8< snip----------- > > So, indeed, we have already multiplied by hardsect_size, struct gendisk > uses sectors of size 512, independent of the hardware, and we must not > again multiply by hardsect_size.
Doh. It's obviously much cleaner and more efficient that way.
Have any of the other patch submitters added a comment to note this in include/linux/genhd.h? hd_struct doesn't have any mention of start_sect and nr_sect being stored in sectors of 512bytes. But maybe that's just to weed out fools like me.
-- ********************************************************* * tpepper@vato dot org * Venimus, Vidimus, * * http://www.vato.org/~tpepper * Dolavimus * ********************************************************* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |