Messages in this thread | | | Date | Wed, 16 Jan 2002 19:50:20 +0100 | From | Jens Axboe <> | Subject | Re: block completion races |
| |
On Wed, Jan 16 2002, Manfred Spraul wrote: > > Also, there is this code in ide_do_drive_cmd(): > > > > if (action == ide_wait) { > > wait_for_completion(&wait); /* wait for it to be serviced */ > > return rq->errors ? -EIO : 0; /* return -EIO if errors */ > > } > > > > Is it safe to use `rq' here? It has just been recycled in > > end_that_request_last() and we don't own it any more. > > > > Yes, this is safe. rq lies on the stack of the caller of > ide_do_drive_cmd() - it can't disappear before we return.
Duh yes of course, I was even preaching this on irc the other day :/
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |