Messages in this thread | | | Date | Tue, 15 Jan 2002 19:43:16 -0500 | From | Benjamin LaHaise <> | Subject | Re: [PATCH] Re: 2.5.3-pre1 compile error |
| |
On Tue, Jan 15, 2002 at 04:29:38PM -0800, Linus Torvalds wrote: > > +#ifndef __ASM__ATOMIC_H > > +#include <asm/atomic.h> > > +#endif > > Please do not assume knowdledge of what the different header files use to > define their re-entrancy.
Well, I actually disagree on this. For large include files (fs.h is the worst), and complicated arrangement, this technique eliminates spurious includes and saves a lot on compile time (really!). If your concern is that the convention is not consistent, I'll gladly patch all of them to use the same format (ie use an __ prefix and escape / to __ and . to _).
-ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |