Messages in this thread | | | Date | Sun, 13 Jan 2002 19:54:49 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] Rx FIFO Overrun error found |
| |
Manfred Spraul wrote: > > Hi all, > > I think I found the reason for the Rx status FIFO overrun nic hang: > If the Rx fifo overflows, the nic sets RxStatusFIFOOver _instead_ of > IntrRxIntr. > Thus netdev_rx is never called, the rx ring is never refilled, nic > hangs. > > The attached patch adds proper OOM handling to natsemi.c. > I've also copied the simpler netdev_close locking from ns83820.c.
Two comments, sis900.c uses the check (rx-overrun | rx-err | rx-ok), did you test that combination? (s/RxStatusFIFOOver/IntrRxOverrun/)
and it would be preferred to separate "add oom handling" and "fix nic hang" patches.
-- Jeff Garzik | Alternate titles for LOTR: Building 1024 | Fast Times at Uruk-Hai MandrakeSoft | The Took, the Elf, His Daughter and Her Lover | Samwise Gamgee: International Hobbit of Mystery - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |