Messages in this thread | | | Date | Tue, 1 Jan 2002 16:43:50 -0700 | From | Tom Rini <> | Subject | Re: [PATCH] C undefined behavior fix |
| |
On Wed, Jan 02, 2002 at 01:03:25AM +0200, Momchil Velikov wrote:
> The appended patch fix incorrect code, which interferes badly with > optimizations in GCC 3.0.4 and GCC 3.1. > > The GCC tries to replace the strcpy from a constant string source with > a memcpy, since the length is know at compile time.
Check the linuxppc-dev archives, but this has been discussed before, and it came down to a few things. 1) gcc shouldn't be making this optimization, and Paulus (who wrote the code) disliked this new feature. As a subnote, what you sent was sent to Linus with a comment about working around a gcc-3.0 bug/feature, and was rejected because of this. 2) We could modify the RELOC macro, and not have this problem. The patch was posted, but not acted upon. 3) We could also try turning off this particular optimization (-fno-builtin perhaps) on this file, and not worry about it.
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |