Messages in this thread | | | Date | Mon, 23 Apr 2001 11:24:21 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] pedantic code cleanup - am I wasting my time with this? |
| |
Jesper Juhl wrote: > > Hi people, > > I'm reading through various pieces of source code to try and get an > understanding of how the kernel works (with the hope that I'll > eventually be able to contribute something really usefull, but you've > got to start somewhere ;) > > While reading through the source I've stumbled across various bits and > pieces that are not exactely wrong, but not strictly correct either. I > was wondering if I would be wasting my time by cleaning this up or if it > would actually be appreciated. One example of these things is the patch > below: > > --- linux-2.4.3-vanilla/include/linux/rtnetlink.h Sun Apr 22 > 02:29:20 2001 > +++ linux-2.4.3/include/linux/rtnetlink.h Mon Apr 23 17:09:02 2001 > @@ -112,7 +112,7 @@ > RTN_PROHIBIT, /* Administratively prohibited */ > RTN_THROW, /* Not in this table */ > RTN_NAT, /* Translate this address */ > - RTN_XRESOLVE, /* Use external resolver */ > + RTN_XRESOLVE /* Use external resolver */ > }; > > #define RTN_MAX RTN_XRESOLVE > @@ -278,7 +278,7 @@ > #define RTAX_CWND RTAX_CWND > RTAX_ADVMSS, > #define RTAX_ADVMSS RTAX_ADVMSS > - RTAX_REORDERING, > + RTAX_REORDERING > #define RTAX_REORDERING RTAX_REORDERING > }; > > @@ -501,7 +501,7 @@ > TCA_OPTIONS, > TCA_STATS, > TCA_XSTATS, > - TCA_RATE, > + TCA_RATE
These patches increase the possibility of errors when adding future items to these lists.
-- Jeff Garzik | The difference between America and England is that Building 1024 | the English think 100 miles is a long distance and MandrakeSoft | the Americans think 100 years is a long time. | (random fortune) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |