Messages in this thread Patch in this message | | | Date | Sat, 21 Apr 2001 15:37:42 +0100 | From | Russell King <> | Subject | Re: x86 rwsem in 2.4.4pre[234] are still buggy [was Re: rwsem benchmarks [Re: generic rwsem [Re: Alpha "process table hang"]]] |
| |
On Sat, Apr 21, 2001 at 04:03:27PM +0200, Andrea Arcangeli wrote: > On Fri, Apr 20, 2001 at 04:45:32PM -0700, Linus Torvalds wrote: > > I would suggest the following: > > > > - the generic semaphores should use the lock that already exists in the > > wait-queue as the semaphore spinlock. > > Ok, that is what my generic code does.
rwsem-spinlock.h requires linux/types.h to be included (you're using __u16 at towards the bottom):
gcc -D__KERNEL__ -I/usr/src2/v2.4/linux-rpc/include -Wall -Wstrict-prototypes -O2 -fno-strict-aliasing -pipe -mapcs-32 -march=armv3m -mtune=strongarm110 -mshort-load-bytes -msoft-float -c -o ieee1284.o ieee1284.c In file included from /usr/src2/v2.4/linux-rpc/include/linux/rwsem.h:56, from /usr/src2/v2.4/linux-rpc/include/asm/semaphore.h:10, from /usr/src2/v2.4/linux-rpc/include/linux/parport.h:101, from ieee1284.c:19: /usr/src2/v2.4/linux-rpc/include/linux/rwsem-spinlock.h:154: parse error before `rwsem_cmpxchgw' /usr/src2/v2.4/linux-rpc/include/linux/rwsem-spinlock.h:154: parse error before `__u16' /usr/src2/v2.4/linux-rpc/include/linux/rwsem-spinlock.h:155: warning: return-type defaults to `int' /usr/src2/v2.4/linux-rpc/include/linux/rwsem-spinlock.h:155: warning: function declaration isn't a prototype
Here is a patch that fixes this oversight against 2.4.4-pre5:
--- orig/include/linux/rwsem-spinlock.h Sat Apr 21 15:32:57 2001 +++ linux/include/linux/rwsem-spinlock.h Sat Apr 21 15:28:45 2001 @@ -11,6 +11,7 @@ #endif #include <linux/spinlock.h> +#include <linux/types.h> #ifdef __KERNEL__
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |