Messages in this thread | | | Date | Fri, 13 Apr 2001 20:13:41 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: EXPORT_SYMBOL for chrdev_open 2.4.3 |
| |
On Fri, 13 Apr 2001, Jeff V. Merkey wrote:
> It would be nice if chrdev_open were added to ksyms.c along with > blkdev_open since tape devices seem are always registered as character > rather than block devices. > > I am finding that kernel modules that need to open and close a tape > drive have to export chrdev_open manually on 2.4.3. Can this get > exported as well? Closing is not a problem since the method of > calling (->release) seems to work OK with SCSI tape devices.
They don't need it. Moreover, blkdev_open shouldn't be exported too - the only potentially modular piece of code that refers to it is drivers/block/rd.c and it's in initrd loading, so it isn't even compiled when we do rd as a module.
BTW, Linus, could we remove blkdev_open() from the export list? I don't see any legitimate reason to export it - certainly not in the official tree.
BTW, fs/partitions/ibm.c also doesn't need blkdev_open() - it should use ioctl_by_bdev() and be done with that. Al
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |