Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 12 Apr 2001 15:40:32 -0400 | From | Jeff Garzik <> | Subject | Re: Proposal for a new PCI function call |
| |
Steve Modica wrote: > > Hi All, > > We found recently that the acenic driver for the 3com gigabit ethernet card does > not enable 64 bit DMAs. (this is done by setting the appropriate mask in > pci_dev->dma_mask). > > Jes suggested that the appropriate way to fix this would be to create a function > like pci_enable_dma64 and then have the driver call that, rather than directly > setting this value (a small handful of drivers do this now). > > I think the function idea would let us do some sanity checking to make sure > drivers weren't setting this to 64bit on non-64 bit busses and stuff.
pci_set_dma_mask. Modify that to do the additional checks you need.
Nobody should be setting dma_mask directly anymore, it should be done through this function.
Jeff
-- Jeff Garzik | Sam: "Mind if I drive?" Building 1024 | Max: "Not if you don't mind me clawing at the dash MandrakeSoft | and shrieking like a cheerleader." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |