Messages in this thread | | | Subject | Re: [PATCH] RFC: fix ethernet device initialization | From | Jes Sorensen <> | Date | 08 Mar 2001 18:35:54 +0100 |
| |
>>>>> "Jeff" == Jeff Garzik <jgarzik@mandrakesoft.com> writes:
Jeff> People from time to time point out a wart in ethernet Jeff> initialization: The net_device is allocated and registered to Jeff> the system in init_etherdev, which is usually one of the first Jeff> things an ethernet driver probe function does. The net_device's Jeff> final members are setup at some time between then and the exit Jeff> of the probe function. There is never a clear point where the Jeff> net device is available to the system for use.
I don't like the way you declare all the code in obscure macros in there.
+#define DECLARE_CHG_MTU(suffix,low,high) \ + static int suffix##_change_mtu(struct net_device *dev, int new_mtu) \ ......
All it does is to make the code harder to read and debug for little/no gain.
Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |