Messages in this thread | | | From | "David S. Miller" <> | Date | Mon, 5 Mar 2001 20:53:21 -0800 (PST) | Subject | Re: SLAB vs. pci_alloc_xxx in usb-uhci patch |
| |
Russell King writes: > A while ago, I looked at what was required to convert the OHCI driver > to pci_alloc_consistent, and it turns out that the current interface is > highly sub-optimal. It looks good on the face of it, but it _really_ > does need sub-page allocations to make sense for USB. > > At the time, I didn't feel like creating a custom sub-allocator just > for USB, and since then I haven't had the inclination nor motivation > to go back to trying to get my USB mouse or iPAQ communicating via USB. > (I've not used this USB port for 3 years anyway).
Gerard Roudier wrote for the sym53c8xx driver the exact thing UHCI/OHCI need for this.
I think people are pissing their pants over the pci_alloc_consistent interface for no reason. It gives PAGE<<order sized/aligned chunks back to the caller at the request of Linus so that drivers did not have to guess "is this 16-byte aligned..." etc.
Later, David S. Miller davem@redhat.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |