Messages in this thread | | | Date | Fri, 23 Mar 2001 06:44:24 -0500 (EST) | From | Alexander Viro <> | Subject | Re: [linux-lvm] EXT2-fs panic (device lvm(58,0)): |
| |
On Thu, 22 Mar 2001, Andreas Dilger wrote:
> If this is the case, then all of the other zero initializations can be > removed as well. I figured that if most of the fields needed to be > zeroed, then ones _not_ being zeroed would lead to this problem.
Other zero initializations in inode->u certainly can be removed, but whether it's worth doing or not depends is a matter of taste (recall the flamefest around Tigran's crusade against global zero initializers several months ago ;-) The rule is that inode->u is zeroed before fs gets to see the inode, be it in ->read_inode() or after get_empty_inode(). The rest is private business of that fs. That's what ->u is about, after all... Cheers, Al
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |