lkml.org 
[lkml]   [2001]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] off-by-1 error in ide-probe (2.4.x)
On Sun, 18 Mar 2001, Linus Torvalds wrote:

>
>
> On Mon, 19 Mar 2001 Andries.Brouwer@cwi.nl wrote:
> >
> > Agreed. That would be a trivially easy bug in the firmware, limiting to
> > 255 sectors seems safer.
> >
> > Linus
> >
> > Yes, possibly.
> > I checked old standards, and see that "0 means 256 as a sector count"
> > is already in ATA-1.
>
> Yes. But we could have some silly bug in the Linux drivers too, if some
> part of the driver reads back the sector count and doesn't do the 0==256
> conversion. So let's not blame the disk quite yet. Although it would be
> interesting to hear if the problem only happens for a specific disk or
> manufacturer...

LT,

This is why I want to standardize the data-phase rules, but we have agreed
to postpone for 2.5. Since the glue for the main loops is spread like hot
butter, it covers up a lot of issues and threads get messy. I had all but
given up on chasing them down and then resolved to start from scratch.


Andre Hedrick
Linux ATA Development

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:29    [W:0.058 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site