Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] lock troubles in pre6-2 | Date | Sun, 06 Aug 2000 00:42:00 +1000 |
| |
In message <200008051306.GAA13426@pizda.ninka.net> you write: > From: Rusty Russell <rusty@linuxcare.com.au> > Date: Sat, 05 Aug 2000 22:42:37 +1000 > > The mm and pcmcia ones look particularly interesting. > > For the mm/vmscan.c one, the "fix" is wrong. > If "result" is ever non-zero, the functions called > have dropped the lock already. See "try_to_swap_out" which is the > only place from non-zero return values can originate in these paths.
Errr... Yeah, I guess I'll take your word for it, because I can't follow that code at all 8(. I see that try_to_swap_out() does an unlock without a lock anywhere in sight, but I can't see the path between this and swap_out_mm().
Please: am I too stupid to understand this, or is the code a convoluted mess?
Must be this warm English beer, Rusty. -- Hacking time.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |