lkml.org 
[lkml]   [2000]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ll_rw_blk.c
On Sun, Mar 19, 2000 at 03:56:28PM +0000, Russell King wrote:

> It's to cover the case where you are loading the kernel from a floppy disk,
> and said kernel does not have the floppy driver configured in. The outb_p
> turns the floppy drives off.
>
> > CONFIG_APUS can only be defined if CONFIG_PPC has been defined, so that's
> > redundant. I _assume_ this is supposed to ACK something that the floppy
> > drive would have ACKed if it were configured in? In any case, this looks
> > really bogus to me, and I think it would probably be better off replaced with
>
> I'd like it see it replaced by a floppy_off() or similar, which the architecture
> can define for itself. Who says that the floppy that you're using to boot is
> controled via port 0x3f2 in all cases?

All my non-Intel boxes turn off the floppy drive after booting even without
this line, so I guess this is more to workaround for a PC-specific BIOS
problem. So why not moving this to arch/i386/kernel/setup.c?

Ralf

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:6.341 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site