lkml.org 
[lkml]   [2000]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] Token Ring Deadlock on SMP


On Mon, 20 Mar 2000, Phillips, Mike wrote:
>
> This should be sufficient for 2.4, we'll put the proper solution (the new
> source routing code) into effect for 2.5

Mike, this part looks pretty wrong:

+ if (!spin_is_locked(&rif_lock) ) {
+ spin_lock_irqsave(&rif_lock,flags);

definitely is buggy. Either use "trylock", or just do them all irq-safe (I
would prefer to get a stupid straightforward "all irqsafe" patch first,
and then try to avoid irq latencies by being clever later. Ok?)

Linus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.050 / U:2.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site