Messages in this thread | | | Date | Tue, 14 Mar 2000 08:50:37 -0800 (PST) | From | Chris Mason <> | Subject | Re: (reiserfs) Re: patch: reiserfs for 2.3.49 |
| |
On Tue, 14 Mar 2000, Alexander Viro wrote: > On Tue, 14 Mar 2000, Chris Mason wrote: > > > We agree, these fixes have already started. We'll send them to you as > > they stabilize. I would much rather have your help getting rid of > > read_inode2 than cleaning up our other messes ;-) > > I need to get fhandle_to_dentry() stable on ext2. From the look at your > code there should be no serious problems with that stuff. > Ok, sounds good.
> > > d) could you please convert symlink.c to pagecache? BTW, that > > > would kill ugly REISERFS_KERNEL_MEM/REISERFS_USER_MEM stuff. > > > > I'll look into this. I'm not sure it is possible to do it right until we > > convert all metadata into the page cache, which we are looking into as > > well. > > Umm... I don't think that it is related. Just define ->readpage() for > symlinks and let it do kmap(), read the body of symlink into the page and > then either SetPageUptodate(),kunmap(),UnlockPage(),return 0 or > SetPageError(), kunmap(), UnlockPage(), return <suitable_error> (if > reading failed, that is). That's it. If your symlink inodes have that in > ->i_mapping->a_op->readpage you can just use page_readlink() and > page_follow_link() in inode_operations. And you get caching of the thing > for free. >
Perfect. I wanted to look more carefully at a_ops for symlinks before saying I could fix it ;-)
thanks, chris
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |