Messages in this thread | | | Date | Wed, 20 Dec 2000 10:04:47 -0600 | From | Jeff Epler <> | Subject | Re: [Patch] performance enhancement for simple_strtoul |
| |
On Wed, Dec 20, 2000 at 09:09:03AM -0500, Steve Grubb wrote: > Hello, > > The following patch is a faster implementation of the simple_strtoul > function. [snip]
Why not preserve the existing code for bases other than 8, 10, and 16? Admittedly, the only other case that is likely to be used would be base 2, but surely there's only a penalty of a few dozen bytes for the following code.. > - while (isxdigit(*cp) && (value = isdigit(*cp) ? *cp-'0' : (islower(*cp) > - ? toupper(*cp) : *cp)-'A'+10) < base) { > - result = result*base + value; > - cp++; > - }
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |