lkml.org 
[lkml]   [2000]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.0-test13-pre1 lockup: run_task_queue or tty_io are wrong
Linus Torvalds wrote:
> > I wasn't clear. The sentinel is a local structure on the stack, and
> > only exists while run_task_queue is executing. Another name for this is
> > "deletion-safe pointer".
>
> Yes, except run_task_queue removes every object it finds. So two
> concurrent run_task_queues would be bad.

That could work, but forget it. I've just looked at Andrew's patch and
it's much nicer :-)

If you put a spinlock around the list operations in Andrew's version,
you'd have safe tqueue deletions again (if you felt that was worth
having). Some tricks and you can make it a different spinlock, but I
doubt that would be a net benefit.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.069 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site