Messages in this thread | | | Date | Tue, 28 Sep 1999 15:02:53 +0200 (MET_DST) | From | David Weinehall <> | Subject | Re: bug in 2.3.18ac9 net/Config.in |
| |
On 28 Sep 1999, Jes Sorensen wrote:
> >>>>> "David" == David Weinehall <tao@acc.umu.se> writes: > > David> On 28 Sep 1999, Jes Sorensen wrote: > >> So we hack Config.in because menuconfig is broken, that really > >> sounds like a stupid solution to me. > >> > >> Having the following in Config.in is _not broken: > >> > >> if [ "$ARCH" = "ppc"] bool "foo" CONFIG_SOME_RANDOM_THING fi if [ > >> "$ARCH" = "mips"] bool "bar" CONFIG_SOME_RANDOM_THING fi > >> > >> Is _not_ broken as long as the condition cannot invoke the question > >> twice. This is just one example of brokenness in the menu based > >> config programs. > > David> As long as you add the proper ';then' to those if's, it works > David> ok with menuconfig too, if I'm not all wrong... It's just > David> xconfig that doesn't work. > > Oh this was not meant to be a perfect running example, I am just > pointing out the principle. However someone changed > fs/partition/Config.in because of exactly this, recently. The result > was that things got messed up for non x86 architectures again and had > to be mended by hand.
But menuconfig is totally innocent, I can't see why you keep blaming things on it. xconfig is the villain here. Oh, I did some of the changes in fs/partition/Config.in, so if you want to blame someone, it's probably me you should blame. I did it to make the code readable, properly indented (this failed, however, because of (guess what?) xconfig being unable to have multiple entries for the same config-option.
Oh, and while you don't test make menuconfig or make xconfig, I don't test make config or make oldconfig, so... There is a place for at least two of them. In my opinion, xconfig isn't really worth keeping, because it's not functional anyway. But hopefully, Michael E. Chastain's new program will cure this.
/David Weinehall _ _ // David Weinehall <tao@acc.umu.se> /> Northern lights wander \\ // Project MCA Linux hacker // Dance across the winter sky // \> http://www.acc.umu.se/~tao/ </ Full colour fire </
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |