lkml.org 
[lkml]   [1999]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch] __lock_sock race condition in 2.3.18*
Date
Hello!

> The real problem I had in fixing this is that tcp_get_info() it's _not_
> buggy and instead it's doing the right thing.

Actually, it was buggy, because locking socket while holding hash lock
is no-no-no.

OK. Actually, you did exactly the thing, which I tried to avoid (new lock)
and, probably, it is better than way which I advocated.
[ I wanted to use normal socket spinlock for this: it is faster,
but results in some aestetical problems. ]

BTW you can kill lhash sleep lock now. rwlock is enough.

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.057 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site