Messages in this thread | | | Date | Tue, 31 Aug 1999 21:35:34 +0200 | From | Martin Mares <> | Subject | Re: PATCH: PCI changes for pre-2.3.16-1 |
| |
> Hey, I kind of agree, which is why I solved essentially the same problem > wrt IP addresses with this "interesting" macro - check for the uses of > NIPQUAD() in the IPv4 networking code. Makes people avoid typing their > fingers to the bone, and in the case of networking it allowed us to have > different unpacking functions on different architectures..
NIPQUAD() is nice, but it still doesn't solve the problem I was speaking about as you still need to have non-trivial things in the format string which I would like to avoid.
Also, for IP addresses you cannot cache the strings :))
pci_dev->slot_name still looks like the best solution to me.
Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "IBM = International Band of Magicians"
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |