lkml.org 
[lkml]   [1999]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: IDE PCI init cleanup
Hi,

> Martin, only one minor nit. You cannot allow drivers to arbitrarily
> change resource values _without_ updating the resource tree. In fact
> this kind of stuff was #if 0'd out in the bttv.c driver for example.
>
> We need to either provide an interface to allow a driver to do this,
> or remove all such instances as the PCI probing boot code should be
> setting these things properly.

Drivers should never change resource values, because they know nothing
about relationship between physical addresses as seen by the kernel and
configuration register contents.

I've already swept out such things from the IDE drivers (I sent
the patch to Andre a few minutes ago) and I'll try to look at the
remaining cases soon.

Have a nice fortnight
--
Martin `MJ' Mares <mj@ucw.cz> http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"Linux _is_ user-friendly. It is not ignorant-friendly and idiot-friendly."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:53    [W:0.054 / U:1.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site