Messages in this thread | | | Date | Wed, 2 Jun 1999 13:40:27 +0200 (CEST) | From | Andrea Arcangeli <> | Subject | Re: 2.2.9 hangs in truncate_inode_pages |
| |
On Tue, 1 Jun 1999, Stephen C. Tweedie wrote:
>It doesn't matter if we end up waiting for the wrong page by mistake: as >long as we don't expect the same page to be there on wakeup, we should >be fine. In truncate_inode_pages(), we do > > if (PageLocked(page)) { > wait_on_page(page); > goto repeat; > } > >which looks safe enough from this respect.
It looks safe to me too because after sleeping we'll restart from &inode->i_pages that will be in a safe state even if the page where we slept over is just been freed by shrink_mmap() in the meantime. It can't be freed while we are browsing the list since we grab the big kernel lock there.
Andrea Arcangeli
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |