Messages in this thread | | | Date | Mon, 8 Mar 1999 05:06:42 +0100 | From | Jan Rekorajski <> | Subject | Re: [PATCH] a.out don't exec over NFS |
| |
On Sun, 07 Mar 1999, Linus Torvalds wrote: > > On Mon, 8 Mar 1999, Jan Rekorajski wrote: > > > > I got the point, and try to work on a.out checks instead of NFS client. > > We might be able to just remove the test for blocksize for the old a.out > support. The blocksize only matters for filesystems that support the bmap > operation, so the a.out test is really not strictly correct anyway. A more > correct thing would probably be to do the blocksize check only if we have > a bmap function for the file. >
You mean mmap? The problem is that most mmaps expects offset to be blocksize aligned. In case of a.out offset is 1024 and if blocksize is != 1024 you may forget running a.out binaries. We can either change a.out header size to 4096 (or 8192) bytes and order everyone to convert binaries, or do a generic mmap(NULL 0, ..., 0); read_exec(); and expect strange things to happen.
BTW, I just tried to "convert" a sample a.out binary and chage the code, it didn't work. The test binary was old doom game and it hanged after a few seconds. :(
Jan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |