lkml.org 
[lkml]   [1999]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: linux/drivers/block/nbd.c
Hi!

> case BLKGETSIZE:
> - return put_user(nbd_bytesizes[dev]/512, (long *) arg);
> + return put_user(nbd_bytesizes[dev] << 9, (long *) arg);
>
> writes << where >> was meant.
> This is in linux/drivers/block/nbd.c.

This escaped me when merging pieces from other people. Someone
overoptimized code a bit. In case you have not already corrected this,
apply following patch. Sorry.

Pavel

PS: Thanks, andreas!

--- clean/drivers/block/nbd.c Wed Mar 10 22:37:25 1999
+++ linux/drivers/block/nbd.c Wed Mar 10 22:36:02 1999
@@ -418,7 +418,7 @@
return 0;
#endif
case BLKGETSIZE:
- return put_user(nbd_bytesizes[dev] << 9, (long *) arg);
+ return put_user(nbd_bytesizes[dev] >> 9, (long *) arg);
}
return -EINVAL;
}

--
I'm really pavel@atrey.karlin.mff.cuni.cz. Pavel
Look at http://atrey.karlin.mff.cuni.cz/~pavel/ ;-).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.045 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site