lkml.org 
[lkml]   [1999]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: TCP FIN-fragment failure in 2.2.x
   Date: Wed, 10 Mar 1999 16:23:00 +0100 (CET)
From: Andrea Arcangeli <andrea@e-mind.com>

On Wed, 10 Mar 1999, David Miller wrote:

>Although probably unrelated, there is a sysctl which turns off a TCP

Woops Dave, now I think I am been wrong again in my comments about Greg's
change. The reason there wasn't FIN on the wire is exactly because the
FIN is shifted in the second packet. I did understood fine how
tcp_fragment() works but I overlooked something again with the
solution under my eyes. Ok, I'll have a good break now...

I think a better (faster) patch could looks like this (the second line
change is just a little improvement):

Nice work, this is certainly it. I'll test this a bit and send it off
to Linus...

BTW, the code was correct when I first wrote it, the "-= nsize" was an
optimization meant to decrease the number of local variables live in
that section of code (for the benefit of gcc's register
allocator)... Oh well.. :-)

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.034 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site