Messages in this thread | | | Date | Sat, 6 Feb 1999 18:13:56 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Linux-2.2.2-pre2.. |
| |
On Sat, 6 Feb 1999, Alexander Viro wrote: > > > Another question: we still have a race in rename() on UNIX > > > filsystems (d_invalidate() stuff). > > > > Remind me.. > > [ reminder ]
Ahh, thanks. I was convinced for some reason that this couldn't happen because we held the parent semaphore, but you're obviously right: even though we hold the parent semaphore it only means that the directory itself cannot be looked up, but somebody who already has the directory looked up (in cwd or similar) wouldn't need to care.
Anyway, the patch looks correct, although I have to admit that it starts to smell like this should all be done in common code at the VFS layer rather than each filesystem having to know about this fairly subtle race. I designed the VFS locking exactly in such a way that the filesystems themselves wouldn't have to care about the directory tree consistency issues.
Would you mind looking into something like that? I'd be grateful,
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |